[PATCH 07/11] apparmor: Fix double free of ns_name in aa_replace_profiles()
authorJohn Johansen <john.johansen@canonical.com>
Wed, 10 Sep 2025 13:22:17 +0000 (06:22 -0700)
committerSalvatore Bonaccorso <carnil@debian.org>
Thu, 12 Mar 2026 12:28:10 +0000 (13:28 +0100)
commitb2c0718617f76c647812df3b9fa6f15d7c5b6fba
tree466e053a37808966dccf6a2e7891402816746aca
parent52063468996fb9114afc26bd89df8e76c04b1680
[PATCH 07/11] apparmor: Fix double free of ns_name in aa_replace_profiles()

if ns_name is NULL after
1071         error = aa_unpack(udata, &lh, &ns_name);

and if ent->ns_name contains an ns_name in
1089                 } else if (ent->ns_name) {

then ns_name is assigned the ent->ns_name
1095                         ns_name = ent->ns_name;

however ent->ns_name is freed at
1262                 aa_load_ent_free(ent);

and then again when freeing ns_name at
1270         kfree(ns_name);

Fix this by NULLing out ent->ns_name after it is transferred to ns_name

Fixes: 04dc715e24d08 ("apparmor: audit policy ns specified in policy load")
Reported-by: Qualys Security Advisory <qsa@qualys.com>
Tested-by: Salvatore Bonaccorso <carnil@debian.org>
Reviewed-by: Georgia Garcia <georgia.garcia@canonical.com>
Reviewed-by: Cengiz Can <cengiz.can@canonical.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Gbp-Pq: Topic bugfix/all/qsa-2026-apparmor
Gbp-Pq: Name 0007-apparmor-Fix-double-free-of-ns_name-in-aa_replace_pr.patch
security/apparmor/policy.c